Skip to content

todo test for GH 5835 (local($^W) does not work correctly) #23546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

todo test for GH 5835 (local($^W) does not work correctly) #23546

merged 1 commit into from
Aug 12, 2025

Conversation

1-1sam
Copy link
Contributor

@1-1sam 1-1sam commented Aug 6, 2025

Add todo test for #5835.

  • This set of changes does not require a perldelta entry.

jkeenan
jkeenan previously requested changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@jkeenan jkeenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mauke, since you were the last person to meaningfully comment in GH #5835 (11 years ago!), could you take a look at this ticket? Thanks.

@khwilliamson khwilliamson dismissed jkeenan’s stale review August 8, 2025 17:02

The requested change actually would lead to this not doing the right thing, as I explained

@tonycoz
Copy link
Contributor

tonycoz commented Aug 11, 2025

I don't think it needs the fresh_perl() - the original issue isn't a crash bug, and #5835 isn't caused by a fault that could lead to a crash.

@jkeenan jkeenan self-requested a review August 12, 2025 15:09
@khwilliamson khwilliamson merged commit 180c7bb into Perl:blead Aug 12, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khwilliamson khwilliamson khwilliamson left review comments

@jkeenan jkeenan jkeenan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1-1sam @tonycoz @jkeenan @khwilliamson